Skip to content

Fix deadlock clearing data on migration failure #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025

Conversation

SessionHero01
Copy link
Collaborator

This PR is to fix this issue on migration error screen: tapping on "clear data" does nothing. See QA-1477.

There are two issues here:

  1. As all database access is blocked waiting on error screen, and the config system was holding a lock while accessing the db, the "clear data" unfortunately will also need access to the config system. The lock then become a deadlock. The solution here is to remove the lock while creating the config from db.
  2. The use of Default dispatcher might not be ideal as all default dispatcher threads are blocked waiting on db. Here for clearing the data, we'll need to use the unconstrained IO dispatcher.

@SessionHero01 SessionHero01 merged commit 1a6234a into dev Apr 23, 2025
4 checks passed
@SessionHero01 SessionHero01 deleted the unable-to-clear-data branch April 23, 2025 04:22
@SessionHero01 SessionHero01 mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants