Add blinded contact records to Contacts and ConvoInfoVolatile #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
reviewed
Jun 16, 2025
jagerman
reviewed
Jun 16, 2025
jagerman
reviewed
Jun 16, 2025
jagerman
reviewed
Jun 16, 2025
jagerman
reviewed
Jun 16, 2025
include/session/config/contacts.hpp
Outdated
| @@ -97,6 +115,47 @@ struct contact_info { | |||
| void load(const dict& info_dict); | |||
| }; | |||
|
|
|||
| struct blinded_contact_info : community { | |||
| using community::community; | |||
There was a problem hiding this comment.
Inheriting from community here feels a little strange, because a blinded contact does not satisfy "is a community" but rather "has a community", and so I think you could do everything here more cleanly by just having a community comm; member instead of inheritance.
There was a problem hiding this comment.
So the main reason for the inheritance was so I could reuse the comm_iterator_helper - I've updated the struct to have a community comm; instead and added the set_{x} functions to redirect to setting the values on the member (not sure if this will work as desired or not 😬)
mpretty-cyro
force-pushed
the
feature/blinded-contacts
branch
from
470d8ad to
47c5164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds blinded contact records to
ContactsandConvoInfoVolatileto simplify syncing them between devices and allowlibSessionto construct the full conversation listNote: This is based on #51