Make the intermediate render targets select the correct size dynamically. #705
Conversation
|
r? @kvark |
| fn new(pass_index: isize, is_framebuffer: bool) -> RenderPass { | ||
| fn new(pass_index: isize, | ||
| is_framebuffer: bool, | ||
| size: DeviceUintSize) -> RenderPass { |
There was a problem hiding this comment.
let's store the size inside a RenderPass in order to avoid asking for it in allocate_target?
There was a problem hiding this comment.
Fixed - had to change the code structure slightly to make this work, but it's much cleaner now.
| // TODO(gw): Remove this hack once the tiling code is sorted out!! | ||
| let max_dimension = cmp::max(screen_rect.size.width, screen_rect.size.height); | ||
| let aligned_max_dimension = (max_dimension + SCREEN_TILE_SIZE - 1) & !(SCREEN_TILE_SIZE-1); | ||
| let cache_size = DeviceUintSize::new(aligned_max_dimension as u32, |
There was a problem hiding this comment.
if this code wasn't temporary, I'd ask for each of width/height to be rounded up separately
There was a problem hiding this comment.
It was originally separate - it actually needs to be square to avoid the rounding glitch in OSMesa :|
| @@ -3,7 +3,7 @@ | |||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| #![cfg_attr(feature = "nightly", feature(nonzero))] | |||
| #![cfg_attr(feature = "serde_derive", feature(proc_macro, rustc_attrs, structural_match))] | |||
There was a problem hiding this comment.
is this no longer needed for serde? I assume there is a compile warning at the moment then.
|
@kvark Thanks for the review - updated to address comments. I'll squash once you're happy with the changes. |
|
@glennw thanks! |
dynamically. The render targets need to be >= framebuffer size, to ensure they can allocate worst case render tasks.
|
@bors-servo r=kvark |
|
📌 Commit e5a3562 has been approved by |
Make the intermediate render targets select the correct size dynamically. The render targets need to be >= framebuffer size, to ensure they can allocate worst case render tasks. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/705) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
The render targets need to be >= framebuffer size, to ensure they
can allocate worst case render tasks.
This change is