Add specific shaders for rectangles with CLIP feature. #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the base rectangle shader include clip makes the software mesa implementation (somewhat) slower for reftests. This is enough of a timing difference that it triggers a lot of intermittent test failures in Servo. Instead, include a simple rectangle shader for workloads that don't have a clip mask. The other shaders are typically more expensive and not used as frequently by the reftests, so hopefully this change is enough to work around the Servo intermittent bugs.
|
r? @kvark and @mrobinson |
|
@bors-servo r+ Hopefully this fixes the issues with the Servo tests. |
|
📌 Commit 18164e5 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Nov 24, 2016
Add specific shaders for rectangles with CLIP feature. Having the base rectangle shader include clip makes the software mesa implementation (somewhat) slower for reftests. This is enough of a timing difference that it triggers a lot of intermittent test failures in Servo. Instead, include a simple rectangle shader for workloads that don't have a clip mask. The other shaders are typically more expensive and not used as frequently by the reftests, so hopefully this change is enough to work around the Servo intermittent bugs. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/591) <!-- Reviewable:end -->
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the base rectangle shader include clip makes the software
mesa implementation (somewhat) slower for reftests. This is enough
of a timing difference that it triggers a lot of intermittent
test failures in Servo.
Instead, include a simple rectangle shader for workloads that
don't have a clip mask.
The other shaders are typically more expensive and not used as
frequently by the reftests, so hopefully this change is enough
to work around the Servo intermittent bugs.
This change is