Use glyph metrics to calculate text run bounds and offsets. #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of rasterizing glyphs, and using that to calculate the bounding box of text runs, use glyph metrics instead. This is important, since it allows us to delay rasterization of glyphs until later in the frame, which means we can delay the decision on whether to rasterize a glyph with subpixel antialising or not. It also removes the concept of "user data" in the texture cache since the resource cache is now used to extract glyph metrics.
|
r? @pcwalton |
|
@bors-servo r=pcwalton,kvark |
|
📌 Commit 4b81528 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 2, 2016
Use glyph metrics to calculate text run bounds and offsets. Instead of rasterizing glyphs, and using that to calculate the bounding box of text runs, use glyph metrics instead. This is important, since it allows us to delay rasterization of glyphs until later in the frame, which means we can delay the decision on whether to rasterize a glyph with subpixel antialising or not. It also removes the concept of "user data" in the texture cache since the resource cache is now used to extract glyph metrics. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/514) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of rasterizing glyphs, and using that to calculate the
bounding box of text runs, use glyph metrics instead.
This is important, since it allows us to delay rasterization of
glyphs until later in the frame, which means we can delay the
decision on whether to rasterize a glyph with subpixel
antialising or not.
It also removes the concept of "user data" in the texture cache
since the resource cache is now used to extract glyph metrics.
This change is