-
Notifications
You must be signed in to change notification settings - Fork 292
Fix 10/12 bits rendering on GLES3 (and core GL3+). #3121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For Windows to display those images properly you need to patch ANGLE
|
(We will hold off on merging this until we update gleam to handle the new format - https://searchfox.org/mozilla-central/source/third_party/rust/gleam/src/gl.rs#59). |
@@ -2223,7 +2223,7 @@ impl Device { | |||
pixel_type: gl::UNSIGNED_BYTE, | |||
}, | |||
ImageFormat::R16 => FormatDesc { | |||
internal: gl::RED as _, | |||
internal: gl::R16 as _, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's fix the internal
format of R8
as well since we are at it (hint: should be R8
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll push another change for that.
@bors-servo r+ |
📌 Commit b662e68 has been approved by |
Fix 10/12 bits rendering on GLES3 (and core GL3+). <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3121) <!-- Reviewable:end -->
@kvark Sorry, I r+'ed before seeing your comment! |
☀️ Test successful - status-appveyor, status-taskcluster |
This change is