-
Notifications
You must be signed in to change notification settings - Fork 43
Rename upstream crates to stylo* #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46c422f
to
1ae821a
Compare
Loirooriol
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have to follow-up depending on the upstream decision, but I guess it's fine for now.
Signed-off-by: Nico Burns <nico@nicoburns.com>
1ae821a
to
9f2ffd4
Compare
2 tasks
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Mar 17, 2025
Changelog: servo/stylo@6aa5733...df459ec This fixes some potential compilation problems since servo/stylo#150 renamed some crates. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
3 tasks
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 17, 2025
Changelog: servo/stylo@6aa5733...df459ec This fixes some potential compilation problems since servo/stylo#150 renamed some crates. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
sagudev
added a commit
to servo/servo
that referenced
this pull request
Mar 25, 2025
This is response to #36128 that is caused by renames that happened in upstream servo/stylo#150. Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
3 tasks
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 25, 2025
This is response to #36128 that is caused by renames that happened in upstream servo/stylo#150. Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 25, 2025
This is response to #36128 that is caused by renames that happened in upstream servo/stylo#150. Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 25, 2025
This is response to #36128 that is caused by renames that happened in upstream servo/stylo#150. Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 25, 2025
This is response to #36128 that is caused by renames that happened in upstream servo/stylo#150. Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 25, 2025
This is response to #36128 that is caused by renames that happened in upstream servo/stylo#150. Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from #131
I have also submitted this upstream (https://bugzilla.mozilla.org/show_bug.cgi?id=1938783) but they are still debating whether they wish to accept the change. We need it either way as it is strictly necessary for publishing to crates.io.