Skip to content

Conversation

@nicoburns
Copy link
Contributor

@nicoburns nicoburns commented Feb 18, 2025

Adds a "Made With Servo" to showcase projects that are built on top of Servo or servo components.

Screenshot 2025-02-19 at 12 34 23

@github-actions
Copy link

github-actions bot commented Feb 18, 2025

Preview link: https://servo.org/made-with-page/made-with/

Copy link
Member

@mrego mrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good. I'm wondering if we should also link other experiments like:

WDYT?

BTW, I left a few nits as small comments.

@nicoburns nicoburns force-pushed the made-with-page branch 2 times, most recently from d12ce2f to 88742ed Compare February 19, 2025 22:47
@github-actions
Copy link

Preview link: https://servo.org/made-with-page/

1 similar comment
@github-actions
Copy link

Preview link: https://servo.org/made-with-page/

@nicoburns
Copy link
Contributor Author

nicoburns commented Feb 19, 2025

I've added the projects you suggested. We can of course add further examples interatively.

@github-actions
Copy link

Preview link: https://servo.org/made-with-page/

1 similar comment
@github-actions
Copy link

Preview link: https://servo.org/made-with-page/

Copy link
Member

@mrego mrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I suggest a small fix for the mobile version.

Other than that, maybe it'd be worth to review the text of the examples, I've added a few suggestions.

Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
@github-actions
Copy link

Preview link: https://servo.org/made-with-page/

@nicoburns nicoburns requested review from mrego and ststimac February 22, 2025 21:12
Copy link
Collaborator

@ststimac ststimac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the requested changes from Delan.

mrego and others added 2 commits February 24, 2025 20:58
Co-authored-by: Delan Azabani <dazabani@igalia.com>
Signed-off-by: Manuel Rego <rego@igalia.com>
Co-authored-by: Delan Azabani <dazabani@igalia.com>
Signed-off-by: Manuel Rego <rego@igalia.com>
@github-actions
Copy link

Preview link: https://servo.org/made-with-page/

1 similar comment
@github-actions
Copy link

Preview link: https://servo.org/made-with-page/

@mrego mrego merged commit 559c6a4 into main Feb 24, 2025
2 checks passed
@mrego mrego deleted the made-with-page branch February 24, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants