-
Notifications
You must be signed in to change notification settings - Fork 23
Add a "made with" page #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview link: https://servo.org/made-with-page/made-with/ |
mrego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d12ce2f to
88742ed
Compare
|
Preview link: https://servo.org/made-with-page/ |
1 similar comment
|
Preview link: https://servo.org/made-with-page/ |
|
I've added the projects you suggested. We can of course add further examples interatively. |
|
Preview link: https://servo.org/made-with-page/ |
1 similar comment
|
Preview link: https://servo.org/made-with-page/ |
mrego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I suggest a small fix for the mobile version.
Other than that, maybe it'd be worth to review the text of the examples, I've added a few suggestions.
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
3e09bfa to
1fd32f4
Compare
|
Preview link: https://servo.org/made-with-page/ |
ststimac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the requested changes from Delan.
Co-authored-by: Delan Azabani <dazabani@igalia.com> Signed-off-by: Manuel Rego <rego@igalia.com>
Co-authored-by: Delan Azabani <dazabani@igalia.com> Signed-off-by: Manuel Rego <rego@igalia.com>
|
Preview link: https://servo.org/made-with-page/ |
1 similar comment
|
Preview link: https://servo.org/made-with-page/ |
Adds a "Made With Servo" to showcase projects that are built on top of Servo or servo components.