This repository was archived by the owner on Dec 16, 2024. It is now read-only.
Re-add additional reviewers for rust-url #1048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
My main issue is the lack of my ability to do "Request reviews" now. |
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 56be29c has been approved by |
Contributor
bors-servo
added a commit
that referenced
this pull request
Jul 11, 2023
Re-add additional reviewers for rust-url Hey, during the [recent Servo TSC Github permission cleanup](servo/rust-url#839 (comment)), @valenting and I lost access to `rust-url` to do reviews. We have been maintaining it for the past year and a bit, and it would be great to have review access again. Is this the right way?
Contributor
|
☔ The latest upstream changes (presumably a15e509) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
💥 Test timed out |
lucacasonato
commented
Jul 12, 2023
Author
lucacasonato
left a comment
lucacasonato
left a comment
There was a problem hiding this comment.
I can't tell whether this is actually needed.
Member
|
With the change to use merge queues this will not be needed. |
Author
|
Great, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, during the recent Servo TSC Github permission cleanup, @valenting and I lost access to
rust-urlto do reviews. We have been maintaining it for the past year and a bit, and it would be great to have review access again. Is this the right way?