-
Notifications
You must be signed in to change notification settings - Fork 361
Attempt to fix 1.82 CI #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix 1.82 CI #1085
Conversation
|
I hoped to get it work with the version-aware resolver, but that doesn't work, the config key is ignored for some reason. Going to fix it the other way. (We can't globally enable it since we test on MSRV 1.63 which doesn't have the resolver) |
|
@hsivonen looks like this fails IdnaTest with latest ICU4X https://github.com/servo/rust-url/actions/runs/18976174234/job/54196290241?pr=1085 Seems to be resolved by updating IdnaTestV2 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage ? 82.25%
=======================================
Files ? 24
Lines ? 4220
Branches ? 0
=======================================
Hits ? 3471
Misses ? 749
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Why are all of the CI tasks immediately getting canceled when one fails? It's making it hard to fix these CI errors since a different one fails with a new one each time: i can never tell if what I am trying is working.
|
a3a35d1 to
a91225c
Compare
ICU4X 2.1 has MSRV 1.83