Skip to content

Conversation

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 31, 2025

ICU4X 2.1 has MSRV 1.83

@Manishearth
Copy link
Member Author

Manishearth commented Oct 31, 2025

I hoped to get it work with the version-aware resolver, but that doesn't work, the config key is ignored for some reason. Going to fix it the other way.

(We can't globally enable it since we test on MSRV 1.63 which doesn't have the resolver)

@Manishearth
Copy link
Member Author

Manishearth commented Oct 31, 2025

@hsivonen looks like this fails IdnaTest with latest ICU4X

https://github.com/servo/rust-url/actions/runs/18976174234/job/54196290241?pr=1085

failures:
    UTS #46 (deprecated API) line 4219
    UTS #46 (deprecated API) line 4220
    UTS #46 (deprecated API) line 4401
    UTS #46 (deprecated API) line 4402
    UTS #46 (deprecated API) line 4403
    UTS #46 (deprecated API) line 4404
    UTS #46 (deprecated API) line 4405
    UTS #46 (deprecated API) line 4408
    UTS #46 (deprecated API) line 4409
    UTS #46 (deprecated API) line 4410
    UTS #46 (deprecated API) line 4411
    UTS #46 line 4219
    UTS #46 line 4220
    UTS #46 line 4405

Seems to be resolved by updating IdnaTestV2

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@9771ab5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage        ?   82.25%           
=======================================
  Files           ?       24           
  Lines           ?     4220           
  Branches        ?        0           
=======================================
  Hits            ?     3471           
  Misses          ?      749           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Manishearth
Copy link
Member Author

Why are all of the CI tasks immediately getting canceled when one fails? It's making it hard to fix these CI errors since a different one fails with a new one each time: i can never tell if what I am trying is working.

fail-fast is not set to true, so I'm not sure what's wrong

@Manishearth Manishearth force-pushed the 182-ci branch 2 times, most recently from a3a35d1 to a91225c Compare October 31, 2025 15:26
@Manishearth Manishearth added this pull request to the merge queue Nov 3, 2025
Merged via the queue into servo:main with commit b06048d Nov 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants