Skip to content

Windows build regularly gets broken #102

Closed
@SimonSapin

Description

@SimonSapin

Since the std::path reform, that module switched to having a single Path type with conditionally-compiled platform-specific behavior instead of separate std::path::unix::Path and std::path::windows::Path types and only a platform-specific re-export as std::path::Path.

rust-url also has some platform specific behavior for converting between Path and file:// URLs. Previously, we could implement traits for both Path types and have that code exist and all platforms. Now that it’s a single type, we have to use #[cfg(…)] to do conditional compilation too.

This is a long way to say that we now have Windows-specific code that is not compiled on Unix. Since I don’t use Windows and Windows is not available on Travis-CI, this code often gets broken without me noticing: #89, #96, #101.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions