Move benchmarks to benches module with noinline wrappers#32
Merged
bors-servo merged 2 commits intoservo:masterfrom Sep 14, 2016
Merged
Move benchmarks to benches module with noinline wrappers#32bors-servo merged 2 commits intoservo:masterfrom
bors-servo merged 2 commits intoservo:masterfrom
Conversation
This ensures that the benchmarks are in a separate crate and linked against the smallvec dynamic library rather than being compiled together.
Contributor
Author
|
Used a #noinline wrapper from benchmarks to get more consistent results. Looks like the results are a bit worse, but more consistent/realistic since the compiler's inlining during the benchmark itself won't affect the performance. |
Contributor
Author
|
I verified by disassembling the generated executables that beforehand, insert() was being inlined, but after this change it is not. This accounts for the dip in the bench_insert |
Contributor
Author
|
Ping on these improvements to the benchmarks. |
Member
|
@bors-servo: r+ |
Contributor
|
📌 Commit 59f5ea6 has been approved by |
Contributor
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Sep 14, 2016
Move benchmarks to benches module with noinline wrappers This ensures that the benchmarks are in a separate crate and linked against the smallvec dynamic library rather than being compiled together. It also nicely removes the need for the "benchmarks" feature. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/32) <!-- Reviewable:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the benchmarks are in a separate crate and linked
against the smallvec dynamic library rather than being compiled
together.
It also nicely removes the need for the "benchmarks" feature.
This change is