Speed up mozangle build on Windows #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mrobinson
commented
Jul 1, 2023
mrobinson
commented
- The source of angle was being compiled into each DLL even though the angle.lib file was passed as an argument to the compiler.
- When compiling on Visual Studio cl the /MP argument enables parallel compilation. This is still serial on clang-cl.exe unfortunately.
- Make the build.rs file more resilient when passing different options. Notably, build_dlls and egl now produce an error on any other platform than Windows.
- Update the version.
mrobinson
force-pushed
the
speed-up-mozangle
branch
2 times, most recently
from
9ace546 to
d11b535
Compare
- The source of angle was being compiled into each DLL even though the angle.lib file was passed as an argument to the compiler. - When compiling on Visual Studio cl the /MP argument enables parallel compilation. This is still serial on clang-cl.exe unfortunately. - Make the build.rs file more resilient when passing different options. Notably, build_dlls and egl now produce an error on any other platform than Windows. - Update the version.
mrobinson
force-pushed
the
speed-up-mozangle
branch
from
d11b535 to
a5125d9
Compare
|
This seems to drop Windows CI times from 30 minutes to 10. |
jdm
approved these changes
Jul 1, 2023
|
@bors-servo r+ |
|
📌 Commit a5125d9 has been approved by |
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.