Add and apply a patch that fixes compiler errors on GCC 13 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It feels like this change should either go into ANGLE itself or mozilla/angle and then pulled downstream. |
|
As talked in servo/servo#29674 there is no problem in upstream (anymore), but bumping gfx/angle would be pretty hard, as it has not been done and probably won't be done for some time, so I believe this should land to allow developers with gcc-13 do other things. |
|
I'll merge this once #55 merges. |
|
@bors-servo r+ |
|
📌 Commit 6799aa6 has been approved by |
|
☀️ Test successful - checks-github |
Merged
bors-servo
added a commit
that referenced
this pull request
Jun 7, 2023
Bump version. This allows servo to pick #54 which fixes my servo build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix servo/servo#29674.