Auto merge of #322 - servo:jdm-patch-5, r=ferjm

Better error messages for audio decoder linking failures. We are hiding useful information unnecessarily.
servo · Nov 21, 2019 · 4250116 · 4250116
2 parents 220ed13 + ce6eba5
commit 4250116
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/backends/gstreamer/audio_decoder.rs b/backends/gstreamer/audio_decoder.rs
@@ -255,8 +255,8 @@ impl AudioDecoder for GStreamerAudioDecoder {
                                 .ok_or(AudioDecoderError::Backend(
                                     "Could not get static pad sink".to_owned(),
                                 ))?;
-                        src_pad.link(&sink_pad).map(|_| ()).map_err(|_| {
-                            AudioDecoderError::Backend("Sink pad link failed".to_owned())
+                        src_pad.link(&sink_pad).map(|_| ()).map_err(|e| {
+                            AudioDecoderError::Backend(format!("Sink pad link failed: {}", e))
                         })
                     };
 
@@ -299,7 +299,7 @@ impl AudioDecoder for GStreamerAudioDecoder {
                 src_pad
                     .link(&sink_pad)
                     .map(|_| ())
-                    .map_err(|_| AudioDecoderError::Backend("Sink pad link failed".to_owned()))
+                    .map_err(|e| AudioDecoderError::Backend(format!("Sink pad link failed: {}", e)))
             };
 
             if let Err(e) = insert_deinterleave() {