Skip to content

Bump MSRV to 1.71 #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Bump MSRV to 1.71 #684

merged 1 commit into from
Oct 28, 2025

Conversation

@simonwuelker
Copy link
Contributor

@simonwuelker simonwuelker commented Oct 28, 2025 •
edited
Loading

Our MSRV is 1.70, parking_lot 0.12.5 needs 1.71. I was not able to tell cargo to pick compatible versions for both parking_lot, parking_lot_core and lock_api. (We can pin parking_lot in Cargo.toml but that seems to make cargo ignore the specified versions for the other two)

1.71 was released in summer of 2023 so upgrading should not be a problem.

@simonwuelker
Copy link
Contributor Author

Unblocks CI for #683

@simonwuelker simonwuelker marked this pull request as draft October 28, 2025 18:04
@simonwuelker
Copy link
Contributor Author

simonwuelker commented Oct 28, 2025 •
edited
Loading

Amanieu/parking_lot#470 (comment)

@simonwuelker simonwuelker changed the title Don't use parking_lot versions newer than 0.12.4 Bump MSRV to 1.71 Oct 28, 2025
@simonwuelker
Bump MSRV to 1.71
90b5e15 
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker simonwuelker marked this pull request as ready for review October 28, 2025 18:11
nicoburns
nicoburns approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, our MSRV is plenty conservative. It's annoying that people bumping MSRV in semver-compatible versions means that the MSRV you choose is pretty meaningless, but that's where we are.

@nicoburns nicoburns added this pull request to the merge queue Oct 28, 2025
Merged via the queue into servo:main with commit e57b106 Oct 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

@nicoburns nicoburns nicoburns approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simonwuelker @jdm @nicoburns