Skip to content

Conversation

@longvatrong111
Copy link
Contributor

#578 made a breaking change to markup5ever: any change to trait item signatures

@jdm jdm added this pull request to the merge queue Mar 11, 2025
Merged via the queue into servo:main with commit 37184cb Mar 11, 2025
6 checks passed
@jdm
Copy link
Member

jdm commented Mar 13, 2025

Published the new versions.

@longvatrong111
Copy link
Contributor Author

xml5ever still depends on markup5ever@0.14.1. Seem like I need to bump version of xml5ever too?

@jdm
Copy link
Member

jdm commented Mar 13, 2025

Ah, yes.

@nicoburns
Copy link
Contributor

@longvatrong111 @jdm I believe this should have been a minor version bump for html5ever and xml5ever too. Those crates both re-export the TreeSink trait that had breaking changes, and thus I believe the latest release of those crates also contained semver-breaking changes.

We should probably republish as 0.30 and 0.21.

@jdm
Copy link
Member

jdm commented Mar 16, 2025

Oof, you're right. I'll yank those versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants