Removing broken Travis webhook integration #117
Conversation
|
cc @Manishearth |
Valloric
force-pushed
the
cleanup
branch
2 times, most recently
from
ea1580b to
503b3e7
Compare
|
cc @cbrewster @edunham @KiChjang @aneeshusa I'd really appreciate a review. :) |
README.md
Outdated
| git clone https://github.com/barosl/homu.git | ||
| pip install -e homu | ||
| $ git clone https://github.com/barosl/homu.git | ||
| $ pip install -e homu |
There was a problem hiding this comment.
I've never used venv so I'm not confident I can write docs explaining to people how they should use it.
Could that be done as a separate PR though? The current PR only reformats the code that's already there, no?
There was a problem hiding this comment.
The venv setup was already there in the README, this pull request removes it. Which we probably don't want.
There was a problem hiding this comment.
Sorry, you're right, I forgot what the original code was doing.
|
unsubmitted review, sorry. r=me with the venv bits fixed |
|
ping @Valloric to add venv bits to readme so we can merge this :) |
|
☔ The latest upstream changes (presumably #124) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Didn't see comments were added, apologies for lack of response! |
|
|
||
| # Development version | ||
|
|
||
| git clone https://github.com/barosl/homu.git |
There was a problem hiding this comment.
while you're at it make this servo instead of barosl
Valloric
force-pushed
the
cleanup
branch
3 times, most recently
from
3d9bf1e to
620ee98
Compare
- Fixed incorrect instructions in the readme. - Added more explanations and example config for Travis & Appveyor, which most users will likely need. Fixes servo#60.
|
Addressed comments and rebased. Again, apologies for the delay! |
|
@bors-servo r+ |
|
📌 Commit 49a8cc3 has been approved by |
Removing broken Travis webhook integration - Fixed incorrect instructions in the readme. - Added more explanations and example config for Travis & Appveyor, which most users will likely need. Fixes #60. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/117) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
which most users will likely need.
Fixes #60.
This change is