This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Update winapi to 0.3.4 #91
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit b1a5eca has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 20, 2018
Update winapi to 0.3.4 `winapi` features enabled - `std` - to make it `c_void` pointer compatible [link](https://docs.rs/winapi/*/x86_64-pc-windows-msvc/src/winapi/lib.rs.html#31) with the one used by heapsize - `heapapi` - to enable `heapapi` [link](https://github.com/retep998/winapi-rs#why-am-i-getting-errors-about-unresolved-imports) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/heapsize/91) <!-- Reviewable:end -->
|
Servo is not using this crate anymore. @debris, out of curiosity, where are you using it? |
|
@SimonSapin we are using it in https://github.com/paritytech/parity |
|
💔 Test failed - status-travis |
|
build failure is unrelated |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 21, 2018
Update winapi to 0.3.4 `winapi` features enabled - `std` - to make it `c_void` pointer compatible [link](https://docs.rs/winapi/*/x86_64-pc-windows-msvc/src/winapi/lib.rs.html#31) with the one used by heapsize - `heapapi` - to enable `heapapi` [link](https://github.com/retep998/winapi-rs#why-am-i-getting-errors-about-unresolved-imports) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/heapsize/91) <!-- Reviewable:end -->
|
lol, either one of the machines cached something or we are very unlucky :D |
|
💔 Test failed - status-travis |
Merged
bors-servo
pushed a commit
that referenced
this pull request
Jan 28, 2018
Update winapi to 0.3.4 reopened #91 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/heapsize/93) <!-- Reviewable:end -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winapifeatures enabledstd- to make itc_voidpointer compatible link with the one used by heapsizeheapapi- to enableheapapilinkThis change is