Add cast and to_* methods to Translation2D/Translation3D
#506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches definitions that exist for `Vector2D`/`Vector3D`. These methods seem as applicable to "translations" as to "vectors". A space may have coordinates in different types, and conversion may be necessary.
ids1024
added a commit
to ids1024/euclid
that referenced
this pull request
Sep 25, 2023
Like servo#506, these exist for the vector types. There doesn't seem to be any reason there shouldn't also work for translation types. The existing `translate` methods could be used for subtraction with `inv`, but that requires a complicated bound involving `Inv` and `Add` instead of a `Sub` bound.
ids1024
added a commit
to ids1024/euclid
that referenced
this pull request
Oct 14, 2023
Like servo#506, these exist for the vector types. There doesn't seem to be any reason there shouldn't also work for translation types. The existing `translate` methods could be used for subtraction with `inv`, but that requires a complicated bound involving `Inv` and `Add` instead of a `Sub` bound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches definitions that exist for
Vector2D/Vector3D.These methods seem as applicable to "translations" as to "vectors". A space may have coordinates in different types, and conversion may be necessary.