Fix TCFType macros for generic types #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is needed to create a type-safe generic abstraction over |
|
Friendly ping @jdm, would you or another maintainer be willing to take a look at this? |
|
@tmandry I'd like to get this unblocked for you. Could you rebase to current |
This adds the following new features: * `declare_TCFType!`: Generics are accepted. * `impl_TCFType!`: Non-defaulted generics are accepted, and impls are fixed to be for all generics. In addition, some warnings are silenced and the macros no longer depend on any traits being in scope in the caller.
|
Thanks for taking a look @waywardmonkeys. Should be ready now. |
waywardmonkeys
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl_TCFType!accepts generic types but some of its impls are missing the generics. They work on types with defaulted generics, but only in the default case. This PR fixes that.It also updates
declare_TCFType!to accept generics as a convenience. We use one PhantomData per parameter, as is already done inimpl_TCFType!.In addition, some warnings are silenced, and the macros no longer depend on any traits being in scope in the caller.