Fix bug in CFArray::to_untyped that made the retain count wrong #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's increase the patch version number and publish a new version as part of this PR. Can we add a test, too? |
|
Sure. I'll fix that! Just a moment. |
|
I realize I only tested |
faern
force-pushed
the
fix-to-untyped-array
branch
from
6d88b3d to
c33598d
Compare
|
@bors-servo: r+ |
|
📌 Commit c33598d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 28, 2017
Fix bug in CFArray::to_untyped that made the retain count wrong The following code segfaults on the `0.4.5` release: ```rust CFArray::<CFBoolean>::from_CFTypes(&[]).to_untyped().to_untyped().to_untyped() ``` Because `to_untyped` don't increment the retain count, but when the typed array it's created from goes out of scope that one will decrement it. And since we need to wrap under the get rule (call `CFRetain`) anyway I did not see any reason to have it as a consuming `to_` method. It's more flexible as a borrowing `as_` method. Since you probably don't want to cause API breakage I kept the old version but fixed the bug and added a deprecation notice on it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/139) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code segfaults on the
0.4.5release:Because
to_untypeddon't increment the retain count, but when the typed array it's created from goes out of scope that one will decrement it.And since we need to wrap under the get rule (call
CFRetain) anyway I did not see any reason to have it as a consumingto_method. It's more flexible as a borrowingas_method.Since you probably don't want to cause API breakage I kept the old version but fixed the bug and added a deprecation notice on it.
This change is