Skip to content

Add non-generic overload of CreateInstance #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 29, 2018
Merged

Add non-generic overload of CreateInstance #5

merged 9 commits into from
Nov 29, 2018

Conversation

hypercodeplace
Copy link
Collaborator

@hypercodeplace hypercodeplace commented Nov 28, 2018 •
edited
Loading

  • Generic types will cause generating of open-generic proxies only;
  • Non-generic overload of CreateInstance is added;
  • Method Initialize is used instead of ctor to improve performance
  • Argument of proxy is changed from Lazy<IService<T>> to Func<object>
  • Class constraint for T is added.

commit-n-run
commit-n-run reviewed Nov 28, 2018
View reviewed changes
commit-n-run
commit-n-run reviewed Nov 28, 2018
View reviewed changes
AlexUstinov
AlexUstinov reviewed Nov 28, 2018
View reviewed changes
@hypercodeplace hypercodeplace merged commit f345fbf into master Nov 29, 2018
@hypercodeplace hypercodeplace deleted the supporting-open-generic branch May 16, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexUstinov AlexUstinov AlexUstinov left review comments

@commit-n-run commit-n-run commit-n-run approved these changes

@botinko botinko Awaiting requested review from botinko

@vchirikov vchirikov Awaiting requested review from vchirikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hypercodeplace @AlexUstinov @commit-n-run