Skip to content

Optimize KeyExpression.Create() #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SergeiPavlov wants to merge 1 commit into
base: master-servicetitan
Choose a base branch
from
Open

Optimize KeyExpression.Create() #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions Orm/Xtensive.Orm/Orm/Linq/Expressions/KeyExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,11 @@
// Created by: Alexis Kochetov
// Created: 2009.05.05

using System.Collections.Generic;
using System.Linq;
using System.Linq.Expressions;
using System.Reflection;
using Xtensive.Core;
using Xtensive.Orm.Internals;
using Xtensive.Orm.Linq.Expressions.Visitors;
using Xtensive.Orm.Model;
using TypeInfo = Xtensive.Orm.Model.TypeInfo;

namespace Xtensive.Orm.Linq.Expressions
Expand Down Expand Up @@ -102,18 +99,25 @@ public override KeyExpression RemoveOuterParameter(Dictionary<Expression, Expres

public static KeyExpression Create(TypeInfo entityType, ColNum offset)
{
var mapping = new Segment<ColNum>(offset, entityType.Key.TupleDescriptor.Count);

FieldExpression CreateField(ColumnInfo c) => FieldExpression.CreateField(c.Field, offset);

var fields = entityType.IsLocked
? entityType.Key.Columns.Select(CreateField).ToArray()
: entityType.Columns
.Where(c => c.IsPrimaryKey)
.OrderBy(c => c.Field.MappingInfo.Offset)
.Select(CreateField)
.ToArray();
return new KeyExpression(entityType, fields, mapping, WellKnownMembers.IEntityKey, null, false);
var entityTypeKey = entityType.Key;
IReadOnlyList<FieldExpression> fields;
if (entityType.IsLocked) {
var columns = entityTypeKey.Columns;
var n = columns.Count;
var ar = new FieldExpression[n];
for (int i = 0; i < n; ++i) {
ar[i] = FieldExpression.CreateField(columns[i].Field, offset);
}
fields = ar;
}
else {
List<FieldExpression> list = new(1);
Copy link

@botinko botinko Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my previous experiment showed, that it's more efficient to count array size entityType.Columns.Count(c => c.IsPrimaryKey) and allocate array of fixed size.

foreach (var c in entityType.Columns.Where(c => c.IsPrimaryKey).OrderBy(c => c.Field.MappingInfo.Offset)) {
list.Add(FieldExpression.CreateField(c.Field, offset));
}
fields = list;
}
return new(entityType, fields, new Segment<ColNum>(offset, entityTypeKey.TupleDescriptor.Count), WellKnownMembers.IEntityKey, null, false);
}

internal override Expression Accept(ExtendedExpressionVisitor visitor) => visitor.VisitKeyExpression(this);
Expand Down