Optimize Translator.VisitMember()
#443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botinko
reviewed
Jan 7, 2026
| private static readonly Type OrmQueryableExtensionsType = typeof(QueryableExtensions); | ||
| private static readonly IReadOnlyList<ParameterExpression> ParameterContextParams = [Expression.Parameter(WellKnownOrmTypes.ParameterContext, "context")]; | ||
| private static readonly ParameterExpression ParameterContextParam = Expression.Parameter(WellKnownOrmTypes.ParameterContext, "context"); | ||
| private static readonly ConcurrentDictionary<(Type Type, MemberInfo MemberInfo), PropertyInfo> memberCache = new(); |
There was a problem hiding this comment.
It looks like it could be kinda big in ST context. Could you measure actual cost of sourceExpression.Type.GetProperty(memberInfo.Name, memberInfo.GetBindingFlags())? Reflection has caches, maybe it's cheap.
Collaborator
Author
There was a problem hiding this comment.
It will be big, but all Type, MemberInfo, PropertyInfo are reused
so we allocate this memory anyway. Just don't want to spend time on reflection logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memoize result of heavy reflection computation