forked from DataObjects-NET/dataobjects-net
-
Notifications
You must be signed in to change notification settings - Fork 3
Merge upstream #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge upstream #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ changelog created
additionally changelog created
For expressions as columns we cast to decimal first because there is a chance it should be done because there is internal cast to decimal and this is the reason that result type of column is decimal, For simple column expressions we probably don't need cast, just trim
renames and summaries, also fixed wrong logic of property and its use
…imscale Apply 'trim_scale' function to results of aggregation to improve compatibility with .NET decimal
- no versions as strings - ability to upgrade model partially - rename Enable -> EnableForVersion for better context on code reading
- no shared domain which should be disposed by next executing test, now tests prepare init database state for themselves and dispose domains they've produced. - added explicitly launched tests for parts of model, which helps to track problems in any happens by isolating part of the model instead of having 100s of changes in upgrade sequence. Main complex upgrade is called as main - organized types of model parts into two arrays and most of the time use array segments to get subset of the types. - places where full namespaces needed where replaces with single storage of namespace - dictionary or constant string, which allow to change namespaces for all mentions at once.
# Conflicts: # Orm/Xtensive.Orm.Tests/Upgrade/DomainUpgradeTest.cs # Orm/Xtensive.Orm.Tests/Upgrade/Models/ModelVersion1.cs # Orm/Xtensive.Orm.Tests/Upgrade/Models/ModelVersion2.cs # Orm/Xtensive.Orm.Tests/Upgrade/Models/ModelVersion3.cs # Orm/Xtensive.Orm.Tests/Upgrade/Upgrader.cs # Version.props
- fix merge issues - add async versions of tests - remove firebird versions of tests (it was taken into account in main test version)
# Conflicts: # Orm/Xtensive.Orm.Tests/Upgrade/Upgrader.cs # Version.props
# Conflicts: # Version.props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.