Optimize Dictionary<> allocation
#393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeiPavlov
changed the title
MaterializationContext readonly structDictionary<> allocation
snaumenko-st
approved these changes
Jun 11, 2025
| @@ -80,16 +80,17 @@ internal TranslatedQuery Translate(ProjectionExpression projection, | |||
| return translatedQuery; | |||
| } | |||
|
|
|||
| private static readonly IReadOnlyList<ColNum> SingleColumn = [0]; | |||
There was a problem hiding this comment.
Maybe it's not worth to keep it in a variable. Compiler should be smart enough to do it on its own.
There was a problem hiding this comment.
Why to rely on compiler if it is easy to make it optimal manually?
And we are not sure about the compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntityMappingCache.ItemsDictionary<> on demandMaterializationContextCtorstaticTranslator.Optimize()string.Contains()extension