Skip to content

Make .GetAttributes() extension internal #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

Make .GetAttributes() extension internal #374

merged 2 commits into from
Apr 17, 2025

Conversation

SergeiPavlov
Copy link
Collaborator

This API is not related to ORM.
The App should have its own Attributes cache

snaumenko-st
snaumenko-st approved these changes Apr 17, 2025
View reviewed changes
Copy link

@snaumenko-st snaumenko-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably perf test this approach again.
There were some optimizations in recent .NET versions and maybe these attributes are cached already somewhere in runtime.

@SergeiPavlov
Copy link
Collaborator Author

There were some optimizations in recent .NET versions and maybe these attributes are cached already somewhere in runtime

I'll benchmark it

@SergeiPavlov SergeiPavlov merged commit 62a0bc7 into master-servicetitan Apr 17, 2025
5 checks passed
@SergeiPavlov SergeiPavlov deleted the GetAttributes branch April 17, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaumenko-st snaumenko-st snaumenko-st approved these changes

@botinko botinko Awaiting requested review from botinko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeiPavlov @snaumenko-st