Skip to content

Fix ambiguity of IEnumerable/IAsyncEnumerable for DelayedQuery #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Dec 21, 2023

@snaumenko-st
Copy link

I'm afraid that if we end up with this fix, we would not be able to easily fix issues related to implicit use of DelayedQuery as IEnumerable in the app.

@SergeiPavlov
Copy link
Collaborator Author

SergeiPavlov commented Dec 21, 2023

I'm afraid that if we end up with this fix, we would not be able to easily fix issues related to implicit use of DelayedQuery as IEnumerable in the app.

That is Ok for our App

  1. But I'm afraid the IAsyncEnumerable on DelayedQuery #170 PR to the Upstream DO repo will be declined as a breaking change.
    And our fork will diverge even more with it.

  2. We have a build issue with Threading Analyzer: error VSTHRD200: Use "Async" suffix in names of methods that return an awaitable type
    Because DelayedQuery is awaitable now

@SergeiPavlov SergeiPavlov marked this pull request as draft December 21, 2023 16:06
@SergeiPavlov SergeiPavlov marked this pull request as ready for review December 21, 2023 17:00
@SergeiPavlov SergeiPavlov marked this pull request as draft December 21, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants