Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring and writing feature part #293

Merged
merged 11 commits into from
Jul 27, 2020
Merged

refactoring and writing feature part #293

merged 11 commits into from
Jul 27, 2020

Conversation

malphi
Copy link
Contributor

@malphi malphi commented Jul 13, 2020 •
edited
Loading

提交 PR 前请先自查以下内容：

在完成项的 [ ] 内填入 x，如：- [x]

  • 我认可本书的版权信息：本书著作权归属于 ServiceMesher 社区，我将保留对所修改内容的署名权。
  • 我已阅读参与贡献说明，并加入了 istio-handbook-wg GitHub team。
  • 我已修改 PR 的标题格式（新增内容 PR 的标题格式为：add: 文档标题，修改已有内容 PR 的标题格式为 update：文档标题）。
  • 我已在该 PR 已指明解决的 issue 链接：issue#1。
  • 我已参考 PR#186 文章内容的格式。
  • 我已阅读并保证所提交 PR 符合写作规范。

@netlify
Copy link

netlify bot commented Jul 13, 2020 •
edited
Loading

Deploy preview for elated-johnson-d0b7ca ready!

Built with commit b7f59f2

https://deploy-preview-293--elated-johnson-d0b7ca.netlify.app

@mergify mergify bot requested a review from a team July 13, 2020 15:15
@rootsongjc rootsongjc added the WIP Working in progress label Jul 13, 2020
@repo-report repo-report bot mentioned this pull request Jul 17, 2020
Closed
@malphi malphi changed the title [WIP] refactoring and writing feature part refactoring and writing feature part Jul 22, 2020
@malphi malphi removed the WIP Working in progress label Jul 23, 2020
@repo-report repo-report bot mentioned this pull request Jul 24, 2020
Closed
rootsongjc
rootsongjc reviewed Jul 26, 2020
View reviewed changes
concepts/traffic-control.md Outdated
除了上面介绍的服务间流量控制外，还能控制与网格边界交互的流量。可以在系统的入口和出口处部署 Sidecar 代理，让所有流入和流出的流量都由代理进行转发。负责入和出的代理就叫做入口网关和出口网关，它们把守着进入和流出网格的流量。下图展示了 Ingress 和 Egress 在请求流中的位置，有了他们俩，也就可以控制出入网格的流量了。

<img src="../images/concept-feature-gateway.png" alt="入口和出口网关" style="zoom:33%;" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这篇文章里的很多图应该都是引用的，需要说明出处。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rootsongjc
rootsongjc reviewed Jul 26, 2020
View reviewed changes
concepts/traffic-control.md Outdated

- VirtualService：用于网格内路由的设置；

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

列表之间不要换行。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mergify mergify bot requested a review from a team July 26, 2020 15:02
rootsongjc
rootsongjc reviewed Jul 26, 2020
View reviewed changes
concepts/traffic-control.md

<img src="../images/concept-trafficcontrol-crd.png" alt="流量crd" style="zoom:50%;" />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最后加一段总结合参考段落。

Copy link
Contributor Author

@malphi malphi Jul 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mergify mergify bot requested a review from a team July 26, 2020 15:02
rootsongjc
rootsongjc approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@mergify mergify bot requested a review from a team July 27, 2020 06:20
@mergify mergify bot merged commit 1ff9de2 into servicemesher:master Jul 27, 2020
@repo-report repo-report bot mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootsongjc rootsongjc rootsongjc approved these changes

Assignees

@malphi malphi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malphi @rootsongjc