Updating security & id portions #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to add the guidance on doing Subject Access reviews ? |
|
I am thinking about leaving that for RC2 or beyond, since different use cases (e.g. using an Operator, or Tekton Pipeline, or a dev directly using SBO, or someone using odo, etc) would probably need different guidance. Right now the spec is just suggesting the metadata declared by the bindable service for the role needed, and leaving the implementation details open. Would be interesting to start prototyping this in SBO, which would likely improve our understanding of the flow. Perhaps we can revisit as part of #31? |
|
Sounds good! |
sbose78
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18 and removes the concept of an
idfor now.The security aspects will be expanded in the future via #31.