Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit the rcon shell by Ctrl-D shortcut. #59

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Exit the rcon shell by Ctrl-D shortcut. #59

merged 1 commit into from
Nov 8, 2017

Conversation

CzBiX
Copy link
Contributor

@CzBiX CzBiX commented Nov 7, 2017

No description provided.

@coveralls
Copy link

coveralls commented Nov 7, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 70.24% when pulling 0f0433e on CzBiX:patch-1 into 2cfbaa5 on serverstf:master.

@Yepoleb
Copy link
Member

Yepoleb commented Nov 7, 2017

It bugs me that _disconnect isn't called. That will leave the connection open until the socket is garbage collected. I know this is happens in the exit implementation as well, so it'd be great if you could fix it there as well, maybe using a shared _exit method. Otherwise a great addition.

@coveralls
Copy link

coveralls commented Nov 8, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.15% when pulling c2981c7 on CzBiX:patch-1 into 2cfbaa5 on serverstf:master.

@Yepoleb
Copy link
Member

Yepoleb commented Nov 8, 2017

Looks good to me. Thanks for your contribution!

@Yepoleb Yepoleb merged commit 5351491 into serverstf:master Nov 8, 2017
@CzBiX CzBiX deleted the patch-1 branch November 8, 2017 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CzBiX @coveralls @Yepoleb