Skip to content

Conversation

@skylerkatz
Copy link
Contributor

Hello!

Thanks for this great repository.

While using Laravel's email validation rules I end up with an exception because the underlying package that they use requires the intl package to be installed.

I created a custom Docker image, but I figured I would submit this as a PR since these images are tuned for Laravel.

@jaydrogers jaydrogers changed the base branch from main to dev June 22, 2022 14:47
@jaydrogers jaydrogers self-assigned this Jun 22, 2022
@jaydrogers jaydrogers added the ⚡️ Enhancement Items that are new features requested to be added. label Jun 22, 2022
@jaydrogers jaydrogers merged commit 1e7ea22 into serversideup:dev Jun 22, 2022
jaydrogers added a commit that referenced this pull request Jun 22, 2022
@jaydrogers
Copy link
Member

Thanks for the PR! I have this merged into dev and it is available on our beta images: https://hub.docker.com/r/serversideup/php/tags?name=beta&page=1&ordering=-name

Could you do me a favor and test it out for me with the package that you're trying to use?

If it does not work, open an issue up and I will get back to you: Open an Issue →

@skylerkatz
Copy link
Contributor Author

Could you do me a favor and test it out for me with the package that you're trying to use?

Just tested and it is working as expected!

Thanks @jaydrogers

@skylerkatz skylerkatz deleted the add-php-intl-package branch June 22, 2022 15:39
@jaydrogers
Copy link
Member

Awesome @skylerkatz! Thanks for your PR!

jaydrogers added a commit that referenced this pull request Oct 25, 2022
* Cleaned up comments

* Added Multi-arch support

* Fixed tage reference

* Removed quotes

* Optimized development script

* Upgraded development to Docker Buildx

* Added upstream support

* Added QEMU

* Added BuildX to production pipeline

* Added platforms

* Removed rare platforms

* Added base ubuntu version

* Re-added upstream channel

* Simplified development process

* Changed S6 Overlay commands to /command

* Refactored to standardized name of 'src' and 'dist'

* Updated warning

* Changed source and dist directories

* Clarified template location

* Added Ubuntu version support

* Updated commands to be compatible with S6 Overlay v3.x

* Updated note to 'dist' folder

* Changed to 'dist' folder

* Centralized workflows

* Removed requirement on calling ubuntu base versions

* Removed null variable

* Removed unused run command

* Set scripts to executable

* Separated build jobs

* Added job dependencies

* Added quotes

* Changed variables to global

* Escaped variables

* Removed environment variables

* Make services executable

* Updated all services to be executable

* Updated to bash

* Added CHMOD at Docker image level

* Fixed PHP variation

* Remove php_admin flags. Fixes #45

* Set security settings to admin flags

* Added PHP_OPEN_BASEDIR. Fixes #52. Thanks to @herpaderpaldent

* add php intl package to support laravel email validation rules

* Completed build for "int" package (ref #56)

* Added Composer variables

* added phpx.x-bcmath

Added `-bcmath` package for php `7.4`, `8.0` and `8.1` as it's a server requirement for Laravel https://laravel.com/docs/9.x/deployment#server-requirements

* Updated README to mermaid

* Upgraded to Ubuntu 22.04

* Updated Ubuntu version to be dynamic

* Added Matrix to workflow

* Updated all references to 22.04

* Restored matrix jobs to be by version only

* Restored base Ubuntu version

* Fixed order of service execution

* Converted to new S6 Overlay format

* Reset build numbers

* Configured working S6 overlay service in new format

* Decreased verbosity

* Converted runas-user to oneshot

* Converted Laravel Automations to new S6 Overlay methods

* Allow versions to be passed to the build command

* Converted Apache to new S6 Overlay standard

* Added S6 verbosity

* Updated NGINX to S6 overlay standard

* Converted services to S6 overlay standards

* Add Readiness Checks (#75)

Add Readiness Checks

* Adjusted upstream names

* Removed debugging

* Adjusted to multi-stage build

* Removed wget

* Adjusted repo config

* Fixed dependency issues

* Cleanup/remove templating (#77)

* Removed build files

* Removed yasha dependency

* Removed variables

* FPM not working

* Fixed PHP-FPM reference

* Fixed version reference

* Static reference to PHP

* Adjusted to listen on TCP only

* Added healthcheck

* Updated actions to new standard

* Clarified Docker Desktop

* Adjusted version to run from the matrix

* Added ca-certificates to repo-config stage

* FIxed READMEs

* Fixed README

* Add PHP 8.2 Support (#78)

* Added 8.2 to security policy

* Added images

* Added 8.2

* Clarified directory

* Alphabetized packages

* Removed php-redis (package not found)

* Allow SSL settings to be configured with "SSL_MODE" (#79)

* Added warning about PHP 8.2

* Tidy up scripts

* Enhanced healthcheck script

* Added documentation for SSL

* Moved cloudflare IPs to standalone file

* Removed default site

* Updated SSL generator for NGINX

* Set execution order for best UX

* Added SSL_MODE support for NGINX

* Improved UX on check script

* Improved UX of service startup

* Set sleep delay for Apache

* Added SSL_MODE support script

* Remove old config

* Added Apache configuration support for SSL_MODE

* Removed redundant exec keyword

* Disable S6 service timeouts (Fixes #81)

* Set the webuser via S6 Overlay's method

* Change production images to only be run on releases

* Revert "Change production images to only be run on releases"

This reverts commit b94f201.

* Cleaned up comments

* Upgraded Github Actions to latest versions

* Added sponsors workflow

* Updated to latest tj-actions/branch-names

Co-authored-by: Skyler Katz <skylerkatz@hey.com>
Co-authored-by: Alex Justesen <alexjustesen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚡️ Enhancement Items that are new features requested to be added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants