-
Notifications
You must be signed in to change notification settings - Fork 70
docs: Update environment variable naming conventions in configuration documentation #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update environment variable naming conventions in configuration documentation #301
Conversation
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe documentation was updated to reflect a new naming convention for environment variables related to secrets in the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase this PR on latest main and we should be GTG 👍
1497168
to
d2ca9e3
Compare
d2ca9e3
to
e1f3d51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Since we have a new way of defining secrets through env (serverpod/serverpod#3656), we should recommend users use this way to define all secrets instead of having special env vars for built-in secrets. This ensures consistency across all secrets, built-in and custom
Summary by CodeRabbit