-
Notifications
You must be signed in to change notification settings - Fork 70
feat: Adds a layer of polish to the documentation. #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis update focuses on restructuring and enhancing the Serverpod documentation. It introduces new tutorials, refines existing guides for clarity and instructional flow, adjusts sidebar and category labels with emojis for improved navigation, and removes outdated or redundant tutorial files. The underlying technical content remains unchanged, with improvements primarily in presentation, organization, and accessibility. Changes
Sequence Diagram(s)No sequence diagrams generated as the changes are limited to documentation structure, content, and navigation improvements without introducing new features or control flow modifications. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (8)
docs/01-get-started/_category_.json (1)
2-2
: Verify title casing in "Getting started"
The rocket emoji is a great touch. Please confirm if the style guide prefers title case ("🚀 Getting Started") instead of sentence case ("🚀 Getting started").docs/01-get-started/01-creating-endpoints.md (1)
199-200
: Consider bulletizing the tip for clarityThe tip is informative but could be split into bullet points to improve readability:
:::tip - Ensure no other Serverpod server is running before starting. - Stop any Docker containers from other Serverpod projects to avoid port conflicts. :::docs/02-overview.md (1)
51-53
: Refine phrasing for clarity.
Consider replacing “talking with the database” with the more idiomatic “talking to the database.”- Serverpod makes it easy to define the data models that your server will use in its API and when talking with the database. + Serverpod makes it easy to define the data models that your server will use in its API and when talking to the database.docs/01-get-started/03-working-with-the-database.md (5)
7-7
: Improve conciseness in the introduction.
Consider shortening "In this section, we will build upon the models we created in the previous section and add a database to store the recipes that users create in the app. This will allow our application to persist data between sessions."
For example:
"Add a database to persist user-created recipes across sessions."
36-39
: Shorten the migrations introduction.
The sentence on line 36 is a bit verbose. You could condense to:
"Serverpod migrations let you safely evolve your database schema over time by generating SQL to update the schema."
53-53
: Use a stronger verb than "giving us."
Replace "giving us access to database operations" with "providing access to database operations" for more formal tone.
426-433
: Surround code fence with blank lines.
Add a blank line before and after the ```bash block starting at line 429 to satisfy markdown-lint (MD031).
439-443
: Surround code fence with blank lines.
Insert a blank line before and after the ```bash block at line 440 to comply with markdown-lint (MD031).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (23)
docs/01-get-started/01-creating-endpoints.md
(1 hunks)docs/01-get-started/02-models-and-data.md
(1 hunks)docs/01-get-started/03-working-with-the-database.md
(3 hunks)docs/01-get-started/04-deployment.md
(3 hunks)docs/01-get-started/_category_.json
(1 hunks)docs/02-overview.md
(4 hunks)docs/04-support.md
(2 hunks)docs/05-tutorials/01-academy.md
(1 hunks)docs/05-tutorials/01-first-app.mdx
(0 hunks)docs/05-tutorials/02-tutorials/01-fundamentals.md
(1 hunks)docs/05-tutorials/02-tutorials/03-ai-and-rag.md
(1 hunks)docs/05-tutorials/02-tutorials/_category_.json
(1 hunks)docs/05-tutorials/03-code-example.md
(0 hunks)docs/05-tutorials/03-guides/_category_.json
(1 hunks)docs/05-tutorials/_category_.json
(1 hunks)docs/06-concepts/_category_.json
(1 hunks)docs/07-deployments/_category_.json
(1 hunks)docs/08-upgrading/_category_.json
(1 hunks)docs/09-tools/_category_.json
(1 hunks)docs/10-contribute.md
(1 hunks)docs/index.md
(5 hunks)docs/serverpod-mini.md
(1 hunks)sidebars.js
(1 hunks)
💤 Files with no reviewable changes (2)
- docs/05-tutorials/03-code-example.md
- docs/05-tutorials/01-first-app.mdx
🧰 Additional context used
🪛 LanguageTool
docs/index.md
[uncategorized] ~148-~148: Possible missing comma found.
Context: ...g. ::: Now that the database is up and running we can start the Serverpod server. Beca...
(AI_HYDRA_LEO_MISSING_COMMA)
docs/02-overview.md
[style] ~25-~25: Try using a synonym here to strengthen your writing.
Context: ...on` provides context about the call and gives access to server resources like the dat...
(GIVE_PROVIDE)
[style] ~51-~51: The preposition ‘with’ is not usually used with the verb ‘talk’. Consider using ‘speak’ instead, or replacing the preposition.
Context: ...our server will use in its API and when talking with the database. You define serializable d...
(TALK_WITH)
docs/01-get-started/03-working-with-the-database.md
[style] ~36-~36: Consider shortening or rephrasing this to strengthen your wording.
Context: ...our database schema over time. When you make changes to your models that affect the database st...
(MAKE_CHANGES)
[style] ~53-~53: Try using a synonym here to strengthen your writing.
Context: ...emodel, it becomes a
TableRow` type, giving us access to database operations. Serverpo...
(GIVE_PROVIDE)
🪛 markdownlint-cli2 (0.17.2)
docs/01-get-started/03-working-with-the-database.md
429-429: Fenced code blocks should be surrounded by blank lines
null
(MD031, blanks-around-fences)
440-440: Fenced code blocks should be surrounded by blank lines
null
(MD031, blanks-around-fences)
🪛 GitHub Check: markdown-lint
docs/01-get-started/03-working-with-the-database.md
[failure] 440-440:
Fenced code blocks should be surrounded by blank lines [Context: "```bash"]
[failure] 429-429:
Fenced code blocks should be surrounded by blank lines [Context: "```bash"]
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test build
🔇 Additional comments (41)
docs/07-deployments/_category_.json (1)
2-2
: Emoji prefix added for Deploying category
Label updated to include the ship emoji for visual consistency with other sections.docs/09-tools/_category_.json (1)
2-2
: Emoji prefix added for Tools category
Label updated to include the toolbox emoji, aligning with the overall sidebar style.docs/08-upgrading/_category_.json (1)
2-2
: Emoji prefix added for Upgrading category
Label updated to include the refresh emoji, matching the pattern of visual cues across docs.docs/06-concepts/_category_.json (1)
2-2
: Emoji prefix added for Reference category
Label updated to include the book emoji, ensuring consistency in emoji-based navigation.docs/05-tutorials/03-guides/_category_.json (1)
1-4
: Add Guides category configuration
The new JSON defining the "📘 Guides" sidebar category is well-formed, aligns with existing category files, and will correctly collapse this section by default.docs/05-tutorials/_category_.json (1)
2-3
: Update main tutorials category label and state
Changing the label to "🎓 Learn Serverpod" and settingcollapsed
tofalse
improves clarity and ensures the section is expanded by default as intended.sidebars.js (1)
21-21
: Emoji-ify the Changelog link
Updating the sidebar link label to "📝 Changelog" maintains consistency with the emoji-first navigation style and enhances visual recognition.docs/serverpod-mini.md (1)
1-3
: Add sidebar_label frontmatter
Introducingsidebar_label: 🐣 Serverpod Mini
ensures this document is correctly represented in the sidebar and follows the new labeling convention.docs/05-tutorials/01-academy.md (1)
1-3
: Add sidebar_label for Serverpod Academy
Includingsidebar_label: 🏫 Serverpod Academy
in the frontmatter properly integrates this new tutorial into the sidebar and matches the overall documentation style.docs/05-tutorials/02-tutorials/_category_.json (1)
1-4
: Approve JSON category configurationThe new
_category_.json
correctly sets the "🎥 Tutorials" label and collapsed default. It aligns with the restructured tutorials section.docs/10-contribute.md (1)
1-3
: Approve sidebar_label frontmatterThe YAML frontmatter adds the sidebar label "🛣️ Roadmap & contributions" and is formatted correctly. Navigation consistency is maintained.
docs/05-tutorials/02-tutorials/01-fundamentals.md (1)
1-7
: Approve new "Backend fundamentals" tutorialThe title, description, and embedded video are clear and consistent with the tutorials section. No issues found.
docs/01-get-started/02-models-and-data.md (1)
44-44
: Approve updated file path and method return type instructionThe correction to
lib/src/recipes/recipe_endpoint.dart
and the guidance to return aRecipe
object are accurate and improve clarity.docs/01-get-started/01-creating-endpoints.md (1)
1-3
: Approve frontmatter sidebar_label updateThe
sidebar_label: 1. Creating endpoint methods
frontmatter is correctly added and follows the pattern of the Getting Started section.docs/02-overview.md (5)
1-3
: Add consistent sidebar label.
The new YAML front matter withsidebar_label: 🧭 Overview
aligns with the navigation enhancements in other docs.
7-7
: Standardize terminology to PostgreSQL.
Replacing “Postgres” with “PostgreSQL” here ensures technical accuracy and consistency.
12-15
: Enhance capability bullets.
The refined bullet points for logging, ORM, and migrations improve clarity and align with the project’s style.
25-27
: Polish endpoint introduction.
The description of endpoint definitions and code examples is clear and well-formatted.
80-97
: Approve database integration section cleanup.
The updates to the database integration and migration descriptions are consistent and free of hidden formatting artifacts.docs/04-support.md (4)
1-3
: Add sidebar label for Support & community.
The new front matter withsidebar_label: 💬 Support & community
matches the style in other sections.
7-7
: Welcome message expanded.
The expanded introduction offers a warm welcome and sets expectations for community support.
9-9
: Correct GitHub capitalization.
Updating “Github” to “GitHub” fixes a typographical inconsistency.
27-31
: Elaborate community video offerings.
The bulleted list clarifies the types of video content available, enhancing user guidance.docs/05-tutorials/02-tutorials/03-ai-and-rag.md (2)
1-4
: New tutorial: Integrating AI & RAG.
The title and introductory text clearly set up the AI/RAG integration tutorial and align with the new tutorials structure.
5-5
: Embed video correctly.
The responsive<div>
and<iframe>
markup follow the pattern used in other tutorial docs.docs/index.md (4)
3-3
: Add Installation sidebar label.
Introducingsidebar_label: 📦 Installation
enhances navigation consistency.
10-11
: Embed introductory video.
The added responsive embed at the top supports varied learning styles.
55-55
: Update “Cloud ready” bullet.
The new link to the waiting list and mention of Terraform support provide actionable next steps.
72-72
: Clarify Docker prerequisite.
This callout about Docker and the database “docker-compose.yaml” file is clear and helpful.docs/01-get-started/04-deployment.md (5)
9-9
: Clarify runtime compilation.
The note on Dart compiling to native code is concise and accurate.
11-11
: Highlight Docker deployment.
Emphasizing the included Dockerfile aligns with user preferences and simplifies onboarding.
13-13
: Detail non-Docker instructions.
The instructions for manual compilation and asset copying accurately reflect current Dart tool limitations.
25-27
: Rename and expand health checks section.
Renaming to “## Health checks” and specifying the root endpoint is clearer for load-balancer configurations.
37-37
: Link to deployment strategies.
The pointer to the broader deployment-strategy guide completes the cross-reference structure.docs/01-get-started/03-working-with-the-database.md (7)
11-11
: Clear ORM instructions.
The guidance on adding thetable
keyword is accurate and easy to follow.
49-49
: Migration history explanation is clear.
This description effectively conveys the purpose and benefits of step-by-step migrations.
428-428
: Instruction step is clear.
The prompt to start the database and apply migrations is concise and accurate.
431-432
: Commands are correct.
Usingdocker compose up -d
and the--apply-migrations
flag is appropriate for development flow.
436-436
: Development tip is clear.
The note on using--apply-migrations
in development versus production is informative and well-phrased.
447-453
: Summary bulleted list is well-structured.
The recap of learned fundamentals is concise and encourages engagement.
456-457
: Advanced tip is informative.
Highlighting the breadth of Serverpod’s ORM and linking to advanced docs adds good guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (6)
docs/01-get-started/03-working-with-the-database.md (6)
7-7
: Shorten and clarify introductory sentenceConsider combining and tightening the phrasing to improve readability:
- In this section, we will build upon the models we created in the previous section and add a database to store the recipes that users create in the app. This will allow our application to persist data between sessions. + In this section, we'll extend our models to add a database for persisting user-created recipes across sessions.
36-38
: Condense migration overview for brevityThis paragraph is quite long. Consider breaking it into shorter sentences or bullets for better scannability:
- Database migrations in Serverpod provide a way to safely evolve your database schema over time. When you make changes to your models that affect the database structure, you need to create a migration. A migration consists of SQL queries that update the database schema to match your model changes. + Serverpod migrations let you safely evolve your database schema. After updating a model that affects the schema, create a migration consisting of SQL queries to apply those changes.
49-49
: Use code formatting for folder nameUse backticks around folder names to prevent unintended italics:
- Each time you run `serverpod create-migration`, a new migration file will be created in your _migrations_ folder. + Each time you run `serverpod create-migration`, a new migration file will be created in your `migrations` folder.
53-53
: Strengthen wording by using 'providing'Replace casual phrasing for a more formal tone:
- it becomes a `TableRow` type, giving us access to database operations. + it becomes a `TableRow` type, providing access to database operations.
426-426
: Remove redundant 'in order'The phrase "in order" is unnecessary since steps imply order already:
- To run the application with database support, follow these steps in order: + To run the application with database support, follow these steps:
455-455
: Consider moderating tone by removing exclamationTo maintain a professional tone, you may want to replace the exclamation with a period:
- We're excited to see what you'll build with Flutter and Serverpod! + We’re excited to see what you’ll build with Flutter and Serverpod.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/01-get-started/03-working-with-the-database.md
(4 hunks)docs/05-tutorials/02-tutorials/02-real-time-communication.md
(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- docs/05-tutorials/02-tutorials/02-real-time-communication.md
🧰 Additional context used
🪛 LanguageTool
docs/01-get-started/03-working-with-the-database.md
[style] ~36-~36: Consider shortening or rephrasing this to strengthen your wording.
Context: ...our database schema over time. When you make changes to your models that affect the database st...
(MAKE_CHANGES)
[style] ~53-~53: Try using a synonym here to strengthen your writing.
Context: ...emodel, it becomes a
TableRow` type, giving us access to database operations. Serverpo...
(GIVE_PROVIDE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test build
🔇 Additional comments (6)
docs/01-get-started/03-working-with-the-database.md (6)
40-41
: Steps to generate migrations are clearThe two-step process (
serverpod generate
→serverpod create-migration
) is well explained and easy to follow.
432-433
: Commands for starting the database and applying migrations look goodClear and correctly ordered.
437-437
: Tip wording is concise and helpfulThe note on
--apply-migrations
usage is clear.
440-440
: Launch instructions are clearThe transition to running the Flutter app is straightforward.
449-454
: Summary bullets effectively reinforce key takeawaysThe bulleted list is clear and consistent.
458-458
: Additional tip is relevant and well-placedThe reference to advanced database docs adds valuable context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move fast and break things 🚀
Do we wan't to apply these changes to older documentations or are we only focusing on improving the newest version of the documentation?
Summary by CodeRabbit