-
Notifications
You must be signed in to change notification settings - Fork 174
Fix small typo in resultEventTimeout description
#689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
resultEventTimeout description
|
Hi! Can you please try changing it in the main branch? You opened a PR to the 0.8.x branch. |
|
seems that main branch does not have these changes yet. |
|
these changes I mean, the v08 additions. |
|
I see. That's fine to change small typos in the current version thou. |
|
I can cherry pick these commits to main if needed. |
tsurdilo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do pr against main branch. ty
|
@tsurdilo seems that the main branch is not updated yet with the v08 additions. |
|
@spolti sorry i dont understand, all prs need to go against the main branch and will be applied to the 0.9 release at this point (and we can cherry-pick to 0.8 branch for things like spelling issues or bugs found). |
|
@tsurdilo what am I saying is that on the main branch, the content I updated, does not exists. |
|
@spolti, as we discussed in the Monday meeting, this content is not valid in the main branch since we deprecated this attribute. |
|
thanks for clarifying |
Many thanks for submitting your Pull Request ❤️!
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does / why we need it:
Special notes for reviewers:
Additional information: