Skip to content

Conversation

@spolti
Copy link
Member

@spolti spolti commented Sep 23, 2022

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Roadmap
  • Use Cases
  • Community
  • TCK
  • Other

Discussion or Issue link:

What this PR does / why we need it:

Special notes for reviewers:

Additional information:

@ricardozanini ricardozanini changed the base branch from 0.8.x to main September 23, 2022 17:55
@ricardozanini ricardozanini changed the base branch from main to 0.8.x September 23, 2022 17:55
@ricardozanini ricardozanini changed the title Update specification.md Fix small typo in resultEventTimeout description Sep 23, 2022
@ricardozanini
Copy link
Member

Hi! Can you please try changing it in the main branch? You opened a PR to the 0.8.x branch.

@spolti spolti changed the base branch from 0.8.x to main September 26, 2022 12:37
@spolti spolti changed the base branch from main to 0.8.x September 26, 2022 12:39
@spolti
Copy link
Member Author

spolti commented Sep 26, 2022

seems that main branch does not have these changes yet.

@spolti
Copy link
Member Author

spolti commented Sep 26, 2022

these changes I mean, the v08 additions.

@ricardozanini
Copy link
Member

I see. That's fine to change small typos in the current version thou.

@spolti
Copy link
Member Author

spolti commented Sep 26, 2022

I can cherry pick these commits to main if needed.

Copy link
Contributor

@tsurdilo tsurdilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do pr against main branch. ty

@tsurdilo tsurdilo added the change: documentation Improvements or additions to documentation. It won't impact a version change. label Sep 30, 2022
@tsurdilo tsurdilo added this to the v0.9 milestone Sep 30, 2022
@spolti
Copy link
Member Author

spolti commented Sep 30, 2022

@tsurdilo seems that the main branch is not updated yet with the v08 additions.

@tsurdilo
Copy link
Contributor

@spolti sorry i dont understand, all prs need to go against the main branch and will be applied to the 0.9 release at this point (and we can cherry-pick to 0.8 branch for things like spelling issues or bugs found).
Are you saying that your changes cannot be applied to main branch? Thanks

@spolti
Copy link
Member Author

spolti commented Sep 30, 2022

@tsurdilo what am I saying is that on the main branch, the content I updated, does not exists.

@ricardozanini
Copy link
Member

ricardozanini commented Sep 30, 2022

@spolti, as we discussed in the Monday meeting, this content is not valid in the main branch since we deprecated this attribute.

@tsurdilo
Copy link
Contributor

tsurdilo commented Oct 1, 2022

thanks for clarifying

@tsurdilo tsurdilo merged commit cf44dda into serverlessworkflow:0.8.x Oct 1, 2022
yzhao244 pushed a commit to yzhao244/specification that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change: documentation Improvements or additions to documentation. It won't impact a version change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants