Skip to content

Fix default values are removed on serialization #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/browser/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</head>
<body>
<!--
Run http-server from the project root then navigate to http://localhost:8080/examples/browser/mermaid.html
Run http-server from the project root then navigate to http://localhost:8080/examples/browser/index.html
-->
<div id="output"></div>
<script src="../../dist/umd/index.umd.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion examples/browser/mermaid.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</head>
<body>
<!--
Run http-server from the project root then navigate to http://localhost:8080/examples/browser/index.html
Run http-server from the project root then navigate to http://localhost:8080/examples/browser/mermaid.html
-->
<div id="mermaid" class="mermaid"></div>
<script src="../../dist/umd/index.umd.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/action-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function actionBuildingFn(data: Specification.Action): () => Specification.Actio
return () => {
const model = new Specification.Action(data);

validate('Action', model);
validate('Action', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/authdef-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function authdefBuildingFn(data: Specification.Authdef): () => Specification.Aut
return () => {
const model = new Specification.Authdef(data);

validate('Authdef', model);
validate('Authdef', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/branch-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function branchBuildingFn(data: Specification.Branch): () => Specification.Branc
return () => {
const model = new Specification.Branch(data);

validate('Branch', model);
validate('Branch', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/callbackstate-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function callbackstateBuildingFn(data: Specification.Callbackstate): () => Speci

setEndValueIfNoTransition(model);

validate('Callbackstate', model);
validate('Callbackstate', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/continueasdef-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function continueasdefBuildingFn(data: Specification.Continueasdef): () => Speci
return () => {
const model = new Specification.Continueasdef(data);

validate('Continueasdef', model);
validate('Continueasdef', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/databasedswitchstate-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function databasedswitchstateBuildingFn(
return () => {
const model = new Specification.Databasedswitchstate(data);

validate('Databasedswitchstate', model);
validate('Databasedswitchstate', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/defaultconditiondef-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function defaultconditiondefBuildingFn(
return () => {
const model = new Specification.Defaultconditiondef(data);

validate('Defaultconditiondef', model);
validate('Defaultconditiondef', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/end-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function endBuildingFn(data: Specification.End): () => Specification.End {
return () => {
const model = new Specification.End(data);

validate('End', model);
validate('End', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/enddatacondition-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function enddataconditionBuildingFn(data: Specification.Enddatacondition): () =>
return () => {
const model = new Specification.Enddatacondition(data);

validate('Enddatacondition', model);
validate('Enddatacondition', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/enddeventcondition-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function enddeventconditionBuildingFn(data: Specification.Enddeventcondition): (
return () => {
const model = new Specification.Enddeventcondition(data);

validate('Enddeventcondition', model);
validate('Enddeventcondition', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/error-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function errorBuildingFn(data: Specification.Error): () => Specification.Error {

setEndValueIfNoTransition(model);

validate('Error', model);
validate('Error', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/eventbasedswitchstate-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function eventbasedswitchstateBuildingFn(
return () => {
const model = new Specification.Eventbasedswitchstate(data);

validate('Eventbasedswitchstate', model);
validate('Eventbasedswitchstate', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/eventdef-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function eventdefBuildingFn(data: Specification.Eventdef): () => Specification.E
return () => {
const model = new Specification.Eventdef(data);

validate('Eventdef', model);
validate('Eventdef', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/eventref-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function eventrefBuildingFn(data: Specification.Eventref): () => Specification.E
return () => {
const model = new Specification.Eventref(data);

validate('Eventref', model);
validate('Eventref', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/eventstate-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function eventstateBuildingFn(data: Specification.Eventstate): () => Specificati

setEndValueIfNoTransition(model);

validate('Eventstate', model);
validate('Eventstate', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/foreachstate-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function foreachstateBuildingFn(data: Specification.Foreachstate): () => Specifi

setEndValueIfNoTransition(model);

validate('Foreachstate', model);
validate('Foreachstate', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/function-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function functionBuildingFn(data: Specification.Function): () => Specification.F
return () => {
const model = new Specification.Function(data);

validate('Function', model);
validate('Function', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/functionref-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function functionrefBuildingFn(data: Specification.Functionref): () => Specifica
return () => {
const model = new Specification.Functionref(data);

validate('Functionref', model);
validate('Functionref', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/injectstate-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function injectstateBuildingFn(data: Specification.Injectstate): () => Specifica

setEndValueIfNoTransition(model);

validate('Injectstate', model);
validate('Injectstate', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/onevents-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function oneventsBuildingFn(data: Specification.Onevents): () => Specification.O
return () => {
const model = new Specification.Onevents(data);

validate('Onevents', model);
validate('Onevents', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/operationstate-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function operationstateBuildingFn(data: Specification.Operationstate): () => Spe

setEndValueIfNoTransition(model);

validate('Operationstate', model);
validate('Operationstate', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/parallelstate-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function parallelstateBuildingFn(data: Specification.Parallelstate): () => Speci

setEndValueIfNoTransition(model);

validate('Parallelstate', model);
validate('Parallelstate', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/sleepstate-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function sleepstateBuildingFn(data: Specification.Sleepstate): () => Specificati
return () => {
const model = new Specification.Sleepstate(data);

validate('Sleepstate', model);
validate('Sleepstate', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/subflowref-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function subflowrefBuildingFn(data: Specification.Subflowref): () => Specificati
return () => {
const model = new Specification.Subflowref(data);

validate('Subflowref', model);
validate('Subflowref', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/timeouts-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function timeoutsBuildingFn(data: Specification.Timeouts): () => Specification.T
return () => {
const model = new Specification.Timeouts(data);

validate('Timeouts', model);
validate('Timeouts', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/transition-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function transitionBuildingFn(data: Specification.Transition): () => Specificati
return () => {
const model = new Specification.Transition(data);

validate('Transition', model);
validate('Transition', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/transitiondatacondition-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function transitiondataconditionBuildingFn(
return () => {
const model = new Specification.Transitiondatacondition(data);

validate('Transitiondatacondition', model);
validate('Transitiondatacondition', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/transitioneventcondition-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function transitioneventconditionBuildingFn(
return () => {
const model = new Specification.Transitioneventcondition(data);

validate('Transitioneventcondition', model);
validate('Transitioneventcondition', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/workflow-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function workflowBuildingFn(data: Specification.Workflow): () => Specification.W
return () => {
const model = new Specification.Workflow(data);

validate('Workflow', model);
validate('Workflow', model.normalize());
return model;
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builders/workflow-exec-timeout-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function workflowExecTimeoutBuildingFn(
return () => {
const model = new Specification.WorkflowExecTimeout(data);

validate('WorkflowExecTimeout', model);
validate('WorkflowExecTimeout', model.normalize());
return model;
};
}
Expand Down
19 changes: 13 additions & 6 deletions src/lib/definitions/action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,30 @@ import { Actiondatafilter } from './actiondatafilter';
import { Eventref } from './eventref';
import { Functionref } from './functionref';
import {
cleanSourceModelProperty,
normalizeEventRef,
normalizeFunctionRef,
normalizeSubFlowRefIfObject,
normalizeSubFlowRef,
overwriteActionDataFilter,
overwriteEventRef,
overwriteFunctionRefIfObject,
overwriteFunctionRef,
overwriteSleep,
overwriteSubFlowRefIfObject,
overwriteSubFlowRef,
} from './utils';
import { Subflowref } from './subflowref';
import { Sleep } from './sleep';

export class Action {
sourceModel?: Action;

constructor(model: any) {
this.sourceModel = Object.assign({}, model);

Object.assign(this, model);

overwriteFunctionRefIfObject(this);
overwriteFunctionRef(this);
overwriteEventRef(this);
overwriteSubFlowRefIfObject(this);
overwriteSubFlowRef(this);
overwriteSleep(this);
overwriteActionDataFilter(this);
}
Expand Down Expand Up @@ -77,10 +82,12 @@ export class Action {
normalize = (): Action => {
const clone = new Action(this);

normalizeSubFlowRefIfObject(clone);
normalizeSubFlowRef(clone);
normalizeEventRef(clone);
normalizeFunctionRef(clone);

cleanSourceModelProperty(clone);

return clone;
};
}
12 changes: 9 additions & 3 deletions src/lib/definitions/authdef.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,19 @@
* limitations under the License.
*/

import { normalizeScheme, overwritePropertiesIfObject } from './utils';
import { cleanSourceModelProperty, normalizeScheme, overwriteProperties } from './utils';
import { Properties } from './types';

export class Authdef {
sourceModel?: Authdef;

constructor(model: any) {
this.sourceModel = Object.assign({}, model);

const defaultModel = { scheme: 'basic' };
Object.assign(this, defaultModel, model);

overwritePropertiesIfObject(this);
overwriteProperties(this);
}
/**
* Unique auth definition name
Expand All @@ -41,7 +45,9 @@ export class Authdef {
normalize = (): Authdef => {
const clone = new Authdef(this);

normalizeScheme(clone);
normalizeScheme(clone, this.sourceModel);

cleanSourceModelProperty(clone);

return clone;
};
Expand Down
Loading