Rename DSL.workflow to DSL.subflow#1311
Merged
fjtirado merged 2 commits intoserverlessworkflow:mainfrom Apr 13, 2026
Merged
Conversation
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Java fluent DSL to use subflow(...) instead of workflow(...) for adding a “run workflow/sub-workflow” task, avoiding the awkward workflow(workflow(...)) nesting described in #1310.
Changes:
- Rename
DSL.workflow(WorkflowConfigurer)toDSL.subflow(WorkflowConfigurer)in the fluent spec DSL. - Update fluent spec tests to use
subflow(...)where a sub-workflow task is configured. - Update implementation tests to use
DSL.subflow(...)when running a child workflow from the DSL.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java | Updates sub-workflow DSL usage to call DSL.subflow(...). |
| fluent/spec/src/test/java/io/serverlessworkflow/fluent/spec/dsl/DSLTest.java | Updates DSL tests to import/use subflow(...) for sub-workflow tasks. |
| fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/dsl/DSL.java | Introduces subflow(WorkflowConfigurer) as the new DSL entrypoint for adding a workflow task. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/dsl/DSL.java
Show resolved
Hide resolved
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Collaborator
Author
|
#1299 must be aligned with the changes from this pull request. cc: @matheusandre1 |
fjtirado
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This pull request aims to change the
workflowtosubflow, it proposes a clear and intuitive DSL when creating subflows using Java DSL, avoindworkflow(workflow.Closes #1310