Skip to content

Rename DSL.workflow to DSL.subflow#1311

Merged
fjtirado merged 2 commits intoserverlessworkflow:mainfrom
mcruzdev:issue-1310
Apr 13, 2026
Merged

Rename DSL.workflow to DSL.subflow#1311
fjtirado merged 2 commits intoserverlessworkflow:mainfrom
mcruzdev:issue-1310

Conversation

@mcruzdev
Copy link
Copy Markdown
Collaborator

Changes

This pull request aims to change the workflow to subflow, it proposes a clear and intuitive DSL when creating subflows using Java DSL, avoind workflow(workflow.

Closes #1310

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@mcruzdev mcruzdev requested a review from fjtirado as a code owner April 13, 2026 14:30
Copilot AI review requested due to automatic review settings April 13, 2026 14:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Java fluent DSL to use subflow(...) instead of workflow(...) for adding a “run workflow/sub-workflow” task, avoiding the awkward workflow(workflow(...)) nesting described in #1310.

Changes:

  • Rename DSL.workflow(WorkflowConfigurer) to DSL.subflow(WorkflowConfigurer) in the fluent spec DSL.
  • Update fluent spec tests to use subflow(...) where a sub-workflow task is configured.
  • Update implementation tests to use DSL.subflow(...) when running a child workflow from the DSL.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java Updates sub-workflow DSL usage to call DSL.subflow(...).
fluent/spec/src/test/java/io/serverlessworkflow/fluent/spec/dsl/DSLTest.java Updates DSL tests to import/use subflow(...) for sub-workflow tasks.
fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/dsl/DSL.java Introduces subflow(WorkflowConfigurer) as the new DSL entrypoint for adding a workflow task.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@mcruzdev
Copy link
Copy Markdown
Collaborator Author

#1299 must be aligned with the changes from this pull request.

cc: @matheusandre1

@fjtirado fjtirado merged commit 3890ed6 into serverlessworkflow:main Apr 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename workflow to subflow

3 participants