Published version 4.0.3.Final does not contains the latest changes

[jrpedrianes]

What happened:

The artifact published into maven central repository seems that is not compiled with the latest changes.

How to reproduce it:

Download the binary from:

• https://repo1.maven.org/maven2/io/serverlessworkflow/serverlessworkflow-validation/4.0.3.Final/serverlessworkflow-validation-4.0.3.Final.jar
• https://repo1.maven.org/maven2/io/serverlessworkflow/serverlessworkflow-validation/4.0.3.Final/serverlessworkflow-validation-4.0.3.Final-sources.jar

And review if the latest changes are applied.

For example, If you go to WorkflowValidatorImpl.java file to line 333, the code must be the next:

                    if (!haveFunctionDefinition(
                        callbackState.getAction().getFunctionRef().getRefName(), functions)) {
                      addValidationError(
                          "CallbackState action function ref does not reference a defined workflow function definition",
                          ValidationError.WORKFLOW_VALIDATION);
                    }

But the code seems that is the old version.

Environment:

• Specification version used: serverlessworkflow-validation-4.0.3.Final

[jrpedrianes]

@tsurdilo could you look at this?

sorry if you are not the guy that handles this, but I saw that you fixed a similar issue. #187

[tsurdilo]

@jrpedrianes thanks for reporting this, will look into it asap.

The change for validation is in 4.0.x branch, not sure how it did not end up in latest release, see cb618c1
and https://github.com/serverlessworkflow/sdk-java/blob/4.0.x/validation/src/main/java/io/serverlessworkflow/validation/WorkflowValidatorImpl.java#L333

Will look at the release jars and try to find out what happened. Thanks.

[tsurdilo]

@jrpedrianes idk what happened buy yes the source jars show the old version you are correct. How urgent is this for you? I could cut 4.0.4.Final release end of this week if thats ok

[jrpedrianes]

@tsurdilo, no problem, is not too urgent when you can fix it will be ok.

[jrpedrianes]

Any news about this?

[tsurdilo]

I haven't done the release yet, sorry. Will do this week.

[jrpedrianes]

any news on this? any plan to get a new release fixing this?

[ricardozanini]

Let me reopen this and close it once we release 4.0.4.

[ricardozanini]

@jrpedrianes can you recheck please?

[jrpedrianes]

I checked right now and is fixed.

Thanks