Conversation
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a Playwright-based E2E testing package to the monorepo and includes an initial test validating the Diagram Editor Storybook render.
Changes:
- Introduces a new
@serverlessworkflow/playwrightworkspace package with Playwright config and scripts. - Adds an initial E2E spec for the Diagram Editor (Storybook iframe route).
- Ignores Playwright output artifacts in
.gitignore.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playwright/tests/diagram-editor.spec.ts | Adds an initial E2E test against the Diagram Editor Storybook iframe. |
| packages/playwright/playwright.config.ts | Configures Playwright base URL and webServer startup for local runs. |
| packages/playwright/package.json | Adds a new workspace package with Playwright dev dependency and scripts. |
| packages/playwright/README.md | Documents how to run the Playwright tests in the monorepo. |
| .gitignore | Ignores Playwright reports/results directories. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
|
@fantonangeli @lornakelly @handreyrc Please review this PR. Thank you. |
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 11 changed files in this pull request and generated 7 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/serverless-workflow-diagram-editor/tests/e2e/diagram-editor.e2e.ts
Show resolved
Hide resolved
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/serverless-workflow-diagram-editor/tests/e2e/diagram-editor.e2e.ts
Show resolved
Hide resolved
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
|
@fantonangeli @lornakelly @handreyrc Please review this PR. |
Close Set up Playwright end-to-end testing
For testing :-
pnpm test:e2eorpnpm test:e2e:ui