Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for options misused in #6546 #6547

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Conversation

dschep
Copy link
Contributor

@dschep dschep commented Aug 15, 2019

What did you implement:

addresses missing docs for options in #6546

How did you implement it:

How can we verify it:

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@dschep dschep requested a review from garethmcc August 15, 2019 13:25
@dschep dschep force-pushed the bucket-sse-kms-key-id-docs branch 2 times, most recently from eb2de89 to 635d08e Compare August 15, 2019 20:54
@medikoo medikoo added this to the 1.51.0 milestone Aug 16, 2019
@dschep dschep merged commit 8445a69 into master Aug 16, 2019
@dschep dschep deleted the bucket-sse-kms-key-id-docs branch August 16, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants