Skip to content

Adhere to Serverless.yml exclude list #13097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

QAnders
Copy link

@QAnders QAnders commented Jun 25, 2025

Solves #12379

Issue is that Docker runs as root and adds persistence directories as owner root and globby throws as it has no access. The code is set to fail silently why it just skips excludes and includes all devDependencies as well in final package.

My suggested code will take the package.patterns list and exclude any excluded patterns from the globby reading.

Hence, if I exclude the Docker persistence directories in package.patterns they will not be read by globby and I will get a proper zip with excluded devDependencies.

Closes: #{ISSUE_NUMBER}

Copy link

github-actions bot commented Jun 25, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@QAnders
Copy link
Author

QAnders commented Jun 25, 2025

I have read the CLA Document and I hereby sign the CLA

@QAnders QAnders changed the title Adhere to Serverless.yml exckude list Adhere to Serverless.yml exclude list Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant