Adhere to Serverless.yml exclude list #13097
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #12379
Issue is that Docker runs as
root
and adds persistence directories as ownerroot
andglobby
throws as it has no access. The code is set to fail silently why it just skips excludes and includes alldevDependencies
as well in final package.My suggested code will take the
package.patterns
list and exclude any excluded patterns from theglobby
reading.Hence, if I exclude the Docker persistence directories in
package.patterns
they will not be read byglobby
and I will get a properzip
with excludeddevDependencies
.Closes: #{ISSUE_NUMBER}