You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The documentation for cloudfront is very thin (https://serverless.com/framework/docs/providers/aws/events/cloudfront/). There's a few examples, but there's no complete documentation of all supported params. Since its likely that users have to use a Resources object to describe the Cloudfront distribution in detail, this event type is potentially quite complex to get right. It would be good of the documentation was a bit richer.
For example, there's no mention of the fact that CustomOriginConfig is a required field if using non-s3 origins.
As an example: I notice that in code, the QueryString attribute is hard-coded to false (
), which means that I probably have to "overwrite" the entire origin attribute. I'm suspecting this is quite common for uses-cases where cloudfront/lambda@edge is involved so it would be good if that was documented.
In short: Make it as easy as possible to get cloudfront/lambda@edge right using serverless - also for non-trivial/real-life apps.
The text was updated successfully, but these errors were encountered:
Bug Report
Description
The documentation for cloudfront is very thin (https://serverless.com/framework/docs/providers/aws/events/cloudfront/). There's a few examples, but there's no complete documentation of all supported params. Since its likely that users have to use a
Resources
object to describe the Cloudfront distribution in detail, this event type is potentially quite complex to get right. It would be good of the documentation was a bit richer.For example, there's no mention of the fact that
CustomOriginConfig
is a required field if using non-s3 origins.As an example: I notice that in code, the
QueryString
attribute is hard-coded tofalse
(serverless/lib/plugins/aws/package/compile/events/cloudFront/index.js
Line 181 in c0ec32b
In short: Make it as easy as possible to get cloudfront/lambda@edge right using serverless - also for non-trivial/real-life apps.
The text was updated successfully, but these errors were encountered: