Skip to content

Upgrade to Serverless Framework v3 and the new design #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Nov 5, 2021

Quick preview:

Screen.2021-11-05.11-28.mp4

Here is also a preview with sls offline, however with the v2 of sls-offline (so don't pay attention to the design of sls offline):

Screen.2021-11-05.11-38.mp4

Error:

image

I've opened this PR against master but I guess we'll need a v3 branch with a beta release?

@mnapoli mnapoli requested a review from medikoo November 9, 2021 14:43
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mnapoli. In general it looks good to me. I would just separate non-log related fixes to other PR's and publish them in scope of current major

@mnapoli
Copy link
Contributor Author

mnapoli commented Nov 23, 2021

FYI I removed the peer dependency.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, still it should not be merged to master, but rather pre-3 pre-release branch

@mnapoli mnapoli changed the base branch from master to pre-3 November 23, 2021 14:55
@mnapoli
Copy link
Contributor Author

mnapoli commented Nov 23, 2021

👍 I created the branch and changed the target of the PR.

I will let you take care of anything related to releases as you have a much clearer vision on this than me.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@mnapoli mnapoli merged commit 9dc4028 into serverless:pre-3 Nov 23, 2021
@mnapoli mnapoli deleted the v3-logs branch November 23, 2021 15:29
@medikoo
Copy link
Contributor

medikoo commented Nov 24, 2021

Published at pre-3 tag

@mnapoli
Copy link
Contributor Author

mnapoli commented Nov 24, 2021

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants