-
Notifications
You must be signed in to change notification settings - Fork 230
Upgrade to Serverless Framework v3 and the new design #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mnapoli. In general it looks good to me. I would just separate non-log related fixes to other PR's and publish them in scope of current major
970e34c
to
ccd0bd0
Compare
FYI I removed the peer dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, still it should not be merged to master
, but rather pre-3
pre-release branch
👍 I created the branch and changed the target of the PR. I will let you take care of anything related to releases as you have a much clearer vision on this than me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Published at |
🎉 |
Quick preview:
Screen.2021-11-05.11-28.mp4
Here is also a preview with
sls offline
, however with the v2 ofsls-offline
(so don't pay attention to the design of sls offline):Screen.2021-11-05.11-38.mp4
Error:
I've opened this PR against master but I guess we'll need a
v3
branch with a beta release?