This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: Check for valid index before setting name property #480
+37
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug when using the timer trigger where it tries to set the name of the binding. The name of the binding can't be set since there is no index found (-1) Fixes: serverless#444
|
@mikedingjan thanks for the fix! Any way we can get a unit test or two to validate the change? |
|
@tbarlow12 Thank you for your feedback. I'm also waiting for this fix, because of that I added the unittest :) |
tbarlow12
approved these changes
Jun 30, 2020
|
@mikedingjan and @mikedebock thanks for the help here. This is the 2nd issue I've seen relating to binding creation, and it might be an issue with the backwards compatibility of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug when using the timer trigger where it tries to set the name of the binding. The name of the binding can't be set since there is no index found (-1)
Fixes: #444