Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

fix: Fix log level setting to handle --verbose #475

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

tbarlow12
Copy link
Contributor

What did you implement:

Fix log level setting to handle boolean case, previously expected empty string

Closes #470

How did you implement it:

Updated the conditions to check for boolean in --verbose option, set to most verbose level

How can we verify it:

Run a command with --verbose on the end. Previously failed

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@tbarlow12 tbarlow12 merged commit ddb81ec into master Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying verbose flag fails deployment
1 participant