Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix failing invoke with data path #321

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Conversation

tbarlow12
Copy link
Contributor

Moves data path initialization outside of the constructor and does not replace the data property within options. Instead, passes the contents of the file path to the invoke service.

Fixes #320

Copy link
Contributor

@PIC123 PIC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this cleans up the code quite nicely

@tbarlow12 tbarlow12 merged commit 7adf5d6 into dev Sep 10, 2019
@tbarlow12 tbarlow12 deleted the tabarlow/fix-invoke-path branch September 10, 2019 18:14
tbarlow12 added a commit that referenced this pull request Sep 13, 2019
Moves data path initialization outside of the constructor and does not replace the `data` property within options. Instead, passes the contents of the file path to the invoke service.

Fixes #320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants