Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APIM feature updates #312

Merged
merged 12 commits into from
Sep 6, 2019
Merged

feat: APIM feature updates #312

merged 12 commits into from
Sep 6, 2019

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Sep 5, 2019

APIM configuration can easily bloat your serverless configuration yaml. This PR reduces a lot of the boilerplate APIM configuration in many use cases except for when direct customization is required.

  • Infers APIM operation configuration from HTTP binding
  • Will automatically generate API just by setting apm: true in serverless yaml
  • Will automatically generate default backend pointing to the /api endpoint of your function app
  • Now supports configuring multiple API's in a single configuration
  • Now supports configuring multiple Backends in a single configuration
  • Ability to link an APIM operation to a specific API and backend

Copy link
Contributor

@PIC123 PIC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean! Definitely makes the experience nicer

docs/examples/apim.md Show resolved Hide resolved
@tbarlow12 tbarlow12 closed this Sep 6, 2019
@tbarlow12 tbarlow12 reopened this Sep 6, 2019
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, approved before pulling this down and running. It looks like the new AzureApimPlugin is setting up a deploy lifecycle event. Lines 11 and 17 of azureApimPlugin

src/plugins/apim/azureApimPlugin.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@@ -196,7 +194,7 @@ export abstract class BaseService {
* Log message to Serverless CLI
* @param message Message to log
*/
protected log(message: string, options?: ServerlessLogOptions, entity?: string,) {
protected log(message: string, options?: ServerlessLogOptions, entity?: string, ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Remove last comma and empty space from method header

src/services/loginService.ts Show resolved Hide resolved
@wbreza wbreza merged commit c679b73 into dev Sep 6, 2019
@wbreza wbreza deleted the wabrez/apim-infer-config branch September 6, 2019 15:26
tbarlow12 pushed a commit that referenced this pull request Sep 13, 2019
APIM configuration can easily bloat your serverless configuration yaml. This PR reduces a lot of the boilerplate APIM configuration in many use cases except for when direct customization is required.

  Infers APIM operation configuration from HTTP binding
  Will automatically generate API just by setting apm: true in serverless yaml
  Will automatically generate default backend pointing to the /api endpoint of your function app
  Now supports configuring multiple API's in a single configuration
  Now supports configuring multiple Backends in a single configuration
  Ability to link an APIM operation to a specific API and backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants