Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly deploys to "West US" when provider.location specifies "West US 2" #280

Closed
tbarlow12 opened this issue Aug 29, 2019 · 0 comments
Closed

Incorrectly deploys to "West US" when provider.location specifies "West US 2" #280

tbarlow12 opened this issue Aug 29, 2019 · 0 comments
Assignees
@wbreza @tbarlow12
Labels
bug v1 issues found on v1.x or feature requests

Comments

@tbarlow12
Copy link
Contributor

tbarlow12 commented Aug 29, 2019 •
edited
Loading

Repro steps:

sls create -t azure-nodejs -p myNewApp
# Notice that the `provider.location` setting is West US 2
sls deploy

The region group is sls-wus-dev-myNewApp-rg and the region for the resources is actually West US
@tbarlow12 tbarlow12 added the bug label Aug 29, 2019
@tbarlow12 tbarlow12 added the v1 issues found on v1.x or feature requests label Aug 29, 2019
@tbarlow12 tbarlow12 mentioned this issue Aug 29, 2019
Merged
tbarlow12 added a commit that referenced this issue Aug 29, 2019
@tbarlow12
fix: Use stage, region, resourceGroup and prefix from CLI options (#284)
506ebc6 
Fixes a regression in accepting `region` and `stage` options from CLI to form resource group name. Adds acceptance of `prefix` as well. Does so by configuring each of them in `serverless.service` (`ServerlessAzureConfig`) as one of the first steps of the `BaseService` constructor.

Also puts `location` into `region` inside the config if `location` is specified, but `region` is not.

Resolves #280, #282 and #281
tbarlow12 added a commit that referenced this issue Aug 30, 2019
@tbarlow12
fix: Use stage, region, resourceGroup and prefix from CLI options (#284)
174d09b 
Fixes a regression in accepting `region` and `stage` options from CLI to form resource group name. Adds acceptance of `prefix` as well. Does so by configuring each of them in `serverless.service` (`ServerlessAzureConfig`) as one of the first steps of the `BaseService` constructor.

Also puts `location` into `region` inside the config if `location` is specified, but `region` is not.

Resolves #280, #282 and #281
@tbarlow12 tbarlow12 mentioned this issue Sep 4, 2019
Merged
tbarlow12 added a commit that referenced this issue Sep 4, 2019
@tbarlow12
fix: Add backwards compatibility for location/region keys in config (#…
12e1235 
…305)

The key for Azure Region moved from `location` to `region`. This just adds backwards compatibility so that the value from `location` is stored in the `region` config if no other is specified.

Resolves #280
tbarlow12 added a commit that referenced this issue Sep 13, 2019
@tbarlow12
fix: Use stage, region, resourceGroup and prefix from CLI options (#284)
30f5d1b 
Fixes a regression in accepting `region` and `stage` options from CLI to form resource group name. Adds acceptance of `prefix` as well. Does so by configuring each of them in `serverless.service` (`ServerlessAzureConfig`) as one of the first steps of the `BaseService` constructor.

Also puts `location` into `region` inside the config if `location` is specified, but `region` is not.

Resolves #280, #282 and #281
tbarlow12 added a commit that referenced this issue Sep 13, 2019
@tbarlow12
fix: Add backwards compatibility for location/region keys in config (#…
b5a74d8 
…305)

The key for Azure Region moved from `location` to `region`. This just adds backwards compatibility so that the value from `location` is stored in the `region` config if no other is specified.

Resolves #280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wbreza wbreza

@tbarlow12 tbarlow12

Labels
bug v1 issues found on v1.x or feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wbreza @tbarlow12