feat: Update aws-node-s3-file-replicator with Lift construct
#618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrzesik
reviewed
Jun 17, 2021
There was a problem hiding this comment.
Thanks @fredericbarthelet 🙇 Looks great, I have only one minor suggestion
fredericbarthelet
force-pushed
the
switch-bucket-to-lift
branch
from
cef21e0 to
e22d5cd
Compare
pgrzesik
approved these changes
Jun 17, 2021
pgrzesik
changed the title
aws-node-s3-file-replicator with Lift construct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at reducing required code base to implement and deploy
aws-node-s3-file-replicatorexemple using Lift plugin.The plugin leverages
storageconstructs for both input and output buckets. It deploys required iamStatements to Lambda role policy to interact with those buckets.